Remove IOException from LeafReader#getSumDocFreq and LeafReader#getSumTotalTermFreq signatures - #16060
Conversation
…mTotalTermFreq signatures.
github-actions
Bot
added
module:core/index
module:core/codecs
module:test-framework
labels
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
| try { | ||
| // TODO: make it constant-time by pre-computing during indexing | ||
| long ttf = 0; | ||
| TermsEnum iterator = iterator(); |
There was a problem hiding this comment.
nit: the above two need not to be in try?
| } | ||
| return ttf; | ||
| } catch (IOException e) { | ||
| throw new UncheckedIOException(e); |
There was a problem hiding this comment.
nit: Do we need to add this in changes.txt?
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM
I think we can backport to 10.6 as well
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
3 participants
These are the last ones of this saga. This time the SimpleText codec was again behaving wrong but already had a todo.
relates #16052